Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCSMB-15: Wide Printer Format (2dj) and Wide Printer Format Array (2dja) Formats and CCSMB-16: 3D Print JSON (3dj) #31

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

CCSMB-15: Wide Printer Format (2dj) and Wide Printer Format Array (2dja) Formats and CCSMB-16: 3D Print JSON (3dj) #31

wants to merge 6 commits into from

Conversation

znepb
Copy link

@znepb znepb commented Mar 30, 2024

RFCs for 2dj, 2dja, and 3dj files. Suggestions welcome!

EmmaKnijn
EmmaKnijn requested changes Mar 30, 2024
View reviewed changes
Copy link
Member

@EmmaKnijn EmmaKnijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just change the titles and you'll be good

Standards/CCSMB-15.md Outdated Show resolved Hide resolved
Standards/CCSMB-16.md Outdated Show resolved Hide resolved
@EmmaKnijn
Copy link
Member

LGTM, as its just an import

@EmmaKnijn EmmaKnijn added kind: import from external source Imports from an external source, like an unmaintained standards repository. status: reviews needed A proposal needs reviews. labels Mar 30, 2024
tomodachi94
tomodachi94 requested changes Mar 30, 2024
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just some minor corrections and a few points that should probably be addressed.

Standards/CCSMB-15.md Outdated Show resolved Hide resolved
Standards/CCSMB-15.md Outdated Show resolved Hide resolved
Standards/CCSMB-15.md Show resolved Hide resolved
Standards/CCSMB-15.md Show resolved Hide resolved
znepb and others added 3 commits March 30, 2024 19:19
@znepb @tomodachi94
Update CCSMB-15.md
e7388dc 
Co-authored-by: Tomo <68489118+tomodachi94@users.noreply.github.com>
@znepb @tomodachi94
Update CCSMB-15.md
8b45819 
Co-authored-by: Tomo <68489118+tomodachi94@users.noreply.github.com>
@znepb
Add clarification on that the files should contain
6ea0cd9
MasonGulu
MasonGulu reviewed Apr 3, 2024
View reviewed changes
Copy link

@MasonGulu MasonGulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting mistake in CCSMB-16 should be corrected, and see my comment on CCSMB-15. Once the formatting mistake is corrected I think it is good to merge.

Standards/CCSMB-15.md Show resolved Hide resolved
Standards/CCSMB-16.md Outdated Show resolved Hide resolved
@znepb znepb requested a review from MasonGulu April 3, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmmaKnijn EmmaKnijn EmmaKnijn approved these changes

@tomodachi94 tomodachi94 Awaiting requested review from tomodachi94

@LinearNoodle LinearNoodle Awaiting requested review from LinearNoodle

@MasonGulu MasonGulu Awaiting requested review from MasonGulu

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
kind: import from external source Imports from an external source, like an unmaintained standards repository. status: reviews needed A proposal needs reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@znepb @EmmaKnijn @tomodachi94 @MasonGulu